[Migration-Check]sdk/resourcemanager/costmanagement #25705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Cost Management SDK to use a new code generator (Microsoft (R) Go Code Generator) and upgrades to API version 2025-03-01. The changes include structural improvements, new features, and enhanced API documentation.
Key changes:
- Migration from AutoRest to Go Code Generator
- API version upgrade from 2022-10-01 to 2025-03-01
- Module version bump from v2 to v3
- Addition of new client types (Budgets, CostAllocationRules, Settings, GenerateBenefitUtilizationSummariesReport)
- Enhanced request/response handling with Content-Type headers and improved parameter validation
- Updated documentation and examples
Reviewed changes
Copilot reviewed 70 out of 82 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scheduledactions_client.go | Updated to new API version with improved documentation and parameter handling |
| responses_serde.go | Added new serialization methods for Settings client responses |
| responses.go | Added response types for new clients and updated documentation references |
| query_client_example_test.go | Updated examples with new API version, improved formatting, and reorganized test cases |
| query_client.go | Enhanced parameter validation and updated API version |
| pricesheet_client_example_test.go | Updated examples for new methods and response structures |
| pricesheet_client.go | Replaced Download method with DownloadByBillingAccount and DownloadByInvoice methods |
| polymorphic_helpers.go | Added Settings classification handling and improved null checking |
| options.go | Added options for new clients and updated documentation |
| operations_client_example_test.go | Updated example formatting and response structure |
| operations_client.go | Updated API version and improved documentation |
| models_serde.go | Extensive additions for new model types (Budget, CostAllocationRule, Settings, etc.) |
| interfaces.go | Added SettingClassification interface |
| go.mod | Module version updated from v2 to v3 |
| generatereservationdetailsreport_client_example_test.go | Updated examples with new response structure |
| generatereservationdetailsreport_client.go | Improved documentation and parameter handling |
| generatedetailedcostreportoperationstatus_client_example_test.go | Updated example response structure |
| generatedetailedcostreportoperationstatus_client.go | Enhanced parameter validation |
| generatedetailedcostreportoperationresults_client_example_test.go | Updated example response structure |
| generatedetailedcostreportoperationresults_client.go | Enhanced parameter validation |
| generatedetailedcostreport_client_example_test.go | Updated examples with new response structures |
| fake/polymorphic_helpers.go | Added helper for Settings classification |
| build.go | Removed (no longer needed with new generator) |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate base on PR Azure/azure-rest-api-specs#37377